Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP CNMT parsing #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP CNMT parsing #31

wants to merge 5 commits into from

Conversation

ThatNerdyPikachu
Copy link

@ThatNerdyPikachu ThatNerdyPikachu commented Dec 24, 2018 •
edited
Loading

  • Basic parsing
  • Extended data region support on the Patch type
  • Clippy, rustfmt, etc
  • Add to the binary crate
  • Rebuilding?

@todo
Copy link

todo bot commented Dec 24, 2018

figure out a better way to do this with the different title types. */,

linkle/src/format/cnmt.rs

Lines 12 to 17 in 830e138

title_header: Option<TitleHeader> /* TODO: figure out a better way to do this with the different title types. */,
content_entries: Vec<ContentEntry>,
meta_entries: Option<Vec<MetaEntry>>
}
#[derive(Clone)]

This comment was generated by todo based on a TODO comment in 830e138 in #31. cc @ThatNerdyPikachu.

@ThatNerdyPikachu
Copy link
Author

@roblabla Should from_u8 on TitleType and ContentType be public?

@roblabla
Copy link
Member

I think it's fine if they stay private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThatNerdyPikachu @roblabla